Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kafka Connect] Fix getting list of connector's topics #504

Merged
merged 3 commits into from
May 31, 2021

Conversation

IldarAlmakaev
Copy link

@IldarAlmakaev IldarAlmakaev commented May 30, 2021

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)
Now we can get a valid list of topics that are used by a connector.
If the connector type is SOURCE, then the list is where it sends messages,
If the connector type is SINK, where it consumes from.

After
The connectors are set up to deal with multiple topics. Some of them use regexs or topic, topics properties
Screenshot 2021-05-30 at 19 00 12

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@IldarAlmakaev IldarAlmakaev added type/bug Something isn't working type/enhancement En enhancement to an already existing feature labels May 30, 2021
@IldarAlmakaev IldarAlmakaev added this to the 0.1 milestone May 30, 2021
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 58 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@germanosin germanosin merged commit 721cf0e into master May 31, 2021
@germanosin germanosin deleted the issue-503-connect-topics-list branch May 31, 2021 09:30
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
* [Kafka Connect] Fix getting list of connector's topics

* Fix code style in KafkaConnectService.java

* Fix code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working type/enhancement En enhancement to an already existing feature
Projects
No open projects
Release 0.1
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Kafka Connect: 500 error/NPE and not valid list of connector's topics when getting all connector info
2 participants